Repository navigation
♻️ simplify imports - #284
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the V2 SDK’s grouped-import cleanup.
No open issues 🎉
What changed in this PR
This PR simplifies imports in the Mindee Ruby SDK’s V2 API by adding grouped entry points for products, parameters, and search types.
Changes:
- Adds grouped loaders and updates the top-level product and search imports to use them.
- Replaces individual RAG document imports in the spec with one grouped import.
- Adds
.junieto.gitignore.
| File | Description |
|---|---|
spec/v2/product/extraction/rag_document_spec.rb |
Uses the grouped RAG documents import. |
lib/mindee/v2/search/rag_documents.rb |
Groups RAG document search imports. |
lib/mindee/v2/search/models.rb |
Groups model search imports. |
lib/mindee/v2/search.rb |
Uses grouped search loaders. |
lib/mindee/v2/product/split/params.rb |
Adds a split parameters loader. |
lib/mindee/v2/product/split.rb |
Groups split product imports. |
lib/mindee/v2/product/ocr/params.rb |
Adds an OCR parameters loader. |
lib/mindee/v2/product/ocr.rb |
Groups OCR product imports. |
lib/mindee/v2/product/extraction/rag_documents/params.rb |
Groups RAG document parameter imports. |
lib/mindee/v2/product/extraction/rag_documents.rb |
Groups RAG annotation and parameter imports. |
lib/mindee/v2/product/extraction.rb |
Groups extraction product imports. |
lib/mindee/v2/product/crop/params.rb |
Adds a crop parameters loader. |
lib/mindee/v2/product/crop.rb |
Groups crop product imports. |
lib/mindee/v2/product/classification/params.rb |
Adds a classification parameters loader. |
lib/mindee/v2/product/classification.rb |
Groups classification product imports. |
lib/mindee/v2/product.rb |
Loads the base product and grouped product loaders. |
.gitignore |
Ignores .junie. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes